Cam2image py - #107
Open
clalancette wants to merge 16 commits into
Open
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code on this branch should resolve Issue #85 for quality of service demos in python. I've tested all of the basic functionality of this python code, including:
I used the C++ "showimage" program to be the subscribing side for all of this testing. For the QoS parameter testing, I tested all of the following combinations:
cam2image_py reliable, showimage reliable - works
cam2image_py best effort, showimage best effort - works
cam2image_py reliable, showimage best effort - works
cam2image_py best effort, showimage reliable - doesn't work
From what Mikael told me, this seems to be the expected behavior.
One other thing I wasn't sure about was how I should setup the directory structure. The demos repository seems to be somewhat inconsistent on this, so I just ended up putting the python files image_tools_py/src. If they should go elsewhere, just let me know and I'll move them.
connects to #85